Quoting on a 'phone

Anything about use of this forum : NOT about cycling
Post Reply
Jdsk
Posts: 24972
Joined: 5 Mar 2019, 5:42pm

Quoting on a 'phone

Post by Jdsk »

Problem with attribution of quotes when using a 'phone. Reported here:
viewtopic.php?p=1732879#p1732879

Jonathan
User avatar
admin
Site Admin
Posts: 1516
Joined: 14 Dec 2006, 8:27pm
Location: Lancing, West Sussex
Contact:

Re: Quoting on a 'phone

Post by admin »

What phone?
What browser?
DevonDamo
Posts: 1039
Joined: 24 May 2011, 1:42am

Re: Quoting on a 'phone

Post by DevonDamo »

admin wrote: 27 Oct 2022, 5:30pm What phone?
What browser?
I think I've just been able to replicate this glitch on a laptop (Windows 10, MS Edge). Have a try yourself: if you quote the following post by dmrcycle and add a comment beneath it, your comment will become highlighted as quoted text as though it were dmrcycle who had written it.:
viewtopic.php?p=1732874#p1732874

I tried it by clicking on 'quote' and cutting and pasting everything into a new thread in the 'test' forum and adding the word 'Test' below the quoted text. The result can be seen here:
viewtopic.php?p=1733078#p1733078

(I've tried the same test with other posts, and this glitch didn't happen.)
User avatar
admin
Site Admin
Posts: 1516
Joined: 14 Dec 2006, 8:27pm
Location: Lancing, West Sussex
Contact:

Re: Quoting on a 'phone

Post by admin »

OK, I can reproduce.

For some reason there are three open-quote tags, but only two close-quote tags. So your reply ends up being included in the outer-most quote.

You can work around it by adding a third [/quote] before your reply, but this is a bug.

I'll investigate further.
Jdsk
Posts: 24972
Joined: 5 Mar 2019, 5:42pm

Re: Quoting on a 'phone

Post by Jdsk »

Thanks.

It's just great to have such rapid and constructive responses.

Jonathan
DevonDamo
Posts: 1039
Joined: 24 May 2011, 1:42am

Re: Quoting on a 'phone

Post by DevonDamo »

DevonDamo wrote: 28 Oct 2022, 4:52pm OK, I can reproduce.

For some reason there are three open-quote tags, but only two close-quote tags. So your reply ends up being included in the outer-most quote.

You can work around it by adding a third before your reply, but this is a bug.

I'll investigate further.
admin wrote: 27 Oct 2022, 5:30pm Thanks very much. (And you'll excuse my little meta-joke.)
User avatar
admin
Site Admin
Posts: 1516
Joined: 14 Dec 2006, 8:27pm
Location: Lancing, West Sussex
Contact:

Re: Quoting on a 'phone

Post by admin »

The problem is that phpBB isn't checking for matching pairs of open/close quote tags in the quoted text. It's just wrapping another quote around it.

If there's a missing close-quote, or too many open-quotes, the quote levels get messed up. Anyone quoting the messed-up message will find their reply goes into the quote, unless they spot the lack of matching and add the close-quote manually.

A fix would be to count open and close quotes in the quoted text, and add additional close-quote tags as needed before populating the message for reply. I'll see if anyone else has had this and perhaps fixed it.

To work around: use the "Preview" function to check your message looks sensible, and if the quoting is wrong count the open and close tags and add tags to keep them balanced. In this situation adding a [/quote] before your reply would sort it out.
DevonDamo
Posts: 1039
Joined: 24 May 2011, 1:42am

Re: Quoting on a 'phone

Post by DevonDamo »

admin wrote: 28 Oct 2022, 5:06pmTo work around....
That's a good enough interim solution - will link to this thread when someone's getting tied up with this.
thirdcrank
Posts: 36781
Joined: 9 Jan 2007, 2:44pm

Re: Quoting on a 'phone

Post by thirdcrank »

I don't see it as a work round. It's the way it works. I hope the forum Admin won't feel obliged to try and do anything about it
Jdsk
Posts: 24972
Joined: 5 Mar 2019, 5:42pm

Re: Quoting on a 'phone

Post by Jdsk »

The workaround was proposed because there's a bug.

The bug has already been tracked down by the Admin:
viewtopic.php?t=153649

Jonathan
Tiggertoo
Posts: 475
Joined: 2 Jun 2021, 4:52pm

Re: Quoting on a 'phone

Post by Tiggertoo »

Good grief!!! It's a good job there isn't anything really serious going on around the world right now. :roll:
Post Reply